(WIP) - SDK 2223 DMA Consent Params Implementation #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 50.73% 50.98% +0.24%
==========================================
Files 68 68
Lines 10081 10144 +63
Branches 3864 3884 +20
==========================================
+ Hits 5115 5172 +57
Misses 4708 4708
- Partials 258 264 +6 ☔ View full report in Codecov by Sentry. |
nsingh-branch
approved these changes
Feb 14, 2024
echo-branch
reviewed
Feb 14, 2024
echo-branch
reviewed
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2223 -- Design and implement key/values to represent consent param
Summary
+ (void) setDMAParamsForEEA:(BOOL) eeaRegion AdPersonalizationConsent:(BOOL) adPersonalizationConsent AdUserDataUsageConsent:(BOOL) adUserDataUsageConsent;Motivation
Support new params added in Google Conversion API for DMA Compliance.
Type Of Change
Testing Instructions
-- SDK is sending value of
eeaRegion, with every/v1/install,/v1/open,/v2/event,v1/pageviewrequest.-- SDKis sending value of
adPersonalizationConsent/adUserDataUsageConsentwith every/v1/install,/v1/open,/v2/event,v1/pageviewrequest only if --
eeaRegionistrueOR-
eeaRegionisfalseandadPersonalizationConsent/adUserDataUsageConsentis also set tofalseRef : https://www.notion.so/brancheng/Google-DMA-Compliance-c19ed28d2ea74b2b9fa4d2d77f8cdcbe
cc @BranchMetrics/saas-sdk-devs for visibility.